PDA

View Full Version : open xlsm vs. xls



maxkoy
11-30-2009, 06:22 AM
Hi all,

I have a code where i need to open a other workbook. I works fine with .xls files, but when im trying to open a .xlsm file i just get a error? Anyone knows why?



Private Sub CommandButton1_Click()
Dim i As Integer
Dim pw As String
Dim path As String
Dim clor As String

Application.ScreenUpdating = False

With ListBox1
For i = 0 To .ListCount - 1
If .ListIndex = i Then pw = Range("B" & i + 4).Value
If .ListIndex = i Then path = Range("G" & i + 4).Value
If .ListIndex = i Then clor = Range("I" & i + 4).Select
Next i
End With

'ERROR COMES HERE!
Application.Workbooks.Open Filename:=path

mdmackillop
11-30-2009, 06:40 AM
Are you working in Excel 2007?

maxkoy
11-30-2009, 06:44 AM
Yes its excel 2007 im using.

in advance thanks!!

maxkoy
11-30-2009, 07:41 AM
its error 1004 i get. And the debug mode marks this line
"Application.Workbooks.Open Filename:=path"

Simon Lloyd
11-30-2009, 08:18 AM
Can you supply a sample workbook?, there really shouldn't be a difference in opening xls or xlsm as xl2007 will use compatability mode as needed, it must be something else.

Bob Phillips
11-30-2009, 09:45 AM
Wouldn't your code be better served as



Private Sub CommandButton1_Click()
Dim i As Integer
Dim pw As String
Dim path As String
Dim clor As String

Application.ScreenUpdating = False

With ListBox1

pw = Range("B" & .ListIndex + 4).Value
path = Range("G" & .ListIndex + 4).Value
clor = Range("I" & .ListIndex + 4).Select
End With

Application.Workbooks.Open Filename:=path


What does the variable path contain when it fails?

maxkoy
11-30-2009, 12:36 PM
I just changed the macro settings in excel and i think it did the job.

xld I think you may be right! Will try to use that code i stead :)