Redundant code

[austenr]

I'll admit I am a less than average programmer especially when it comes to logic. I am struggling with something that I can't seem to get mu head around.

Scenerio:

5 text boxes all placed in the same position each layered on top of the other. They are each displayed by a button (textbox1.visible = true) that also controls the visibility non/visibility of other image boxes, etc.

So now I have 5 buttons each controlling the visibility of a specific text box. When I switch to another text box and make it visible I end up making the previous one not visible (textbox1.visible = false). This leaves me turning the same text box invisible 4 times.

I know that this is horrible coding but I can't figure out another way.

If anyone is interested in helping Ill post the code. Thanks for listening.

[Philcjr]

Austen,

How about trying this, this should bring the textbox to the front... once you click on the command button to show a textbox


TextBox1.ZOrder(fmTop)


Will this work for you?

[austenr]

[austenr]

Heres the code tried to post with code tags but it didn't take.

[mdmackillop]

Hi Austen
Can you post a sample workbook containing the userform?
Regards
MD

[p45cal]

Two approaches I would make with this one:
1.Write a sub which makes everything that you might want to make invisible, invisible. Call that sub first in the event handler then only make visible the items you want to be visible.
2.Instead of multiple controls on top of each other, only have one textbox/label etc. and get the code to change its contents with .caption .value and so on. I think you should also be able to change the picture in a similar way.

[austenr]

Thanks for the input guys. Malcomb, this is straight up VB. Well VB.Net.

[austenr]

p45Cal, that might work but once its visible and I want to load another picture would you not have to make whats visible invisible?

[austenr]

How about writing a sub that makes everything invisible then call it inside the sub that is currently being processed?

[austenr]

How about writing a sub that makes everything invisible then call it inside the sub that is currently being processed?

[p45cal]

How about writing a sub that makes everything invisible then call it inside the sub that is currently being processed? That's just what I meant by "Write a sub which makes everything that you might want to make invisible, invisible. Call that sub first in the event handler then only make visible the items you want to be visible."
re:

that might work but once its visible and I want to load another picture would you not have to make whats visible invisible? With Approach 1 that would be covered by your suggestion above.
With Approach 2 I'd have thought the new picture loaded would replace the older one.