VBA wont run unless through the editor

[SimonKD]

I have some VBA code which is supposed to take an excel worksheet, copy it and email the copy. This has been working fine for the last few months but recently the office machines were updated to windows 7 and it's stopped working.

If I open the excel file and click the button on the worksheet I have it set to use then the code works (copies file, attaches to email) but stops at clicking send in outlook. But if though I run the code from the VBA editor it works perfectly... :think:

I'm lost...

[SamT]

We can't see anything wrong with the code.

[Paul_Hossler]

We can't see anything wrong with the code.

:rotlaugh::rotlaugh::rotlaugh:

[snb]

It must have been inadvertently turned to
code.invisible=true

[Aussiebear]

Welcome to the VBAX forum, and sorry about the delay in the welcome.


I have some VBA code

Please don't be offended by the comments above. The truth is, if you dont post the code to the forum, we can't review it.

And to you other three......:rtfm:

[SimonKD]

Sorry about that...




Sub Mail_workbook_Outlook_2()




'If score is less than 80% then User cannot save.
If Worksheets("Score Sheet").Range("K21").Value <= "63" Then


MsgBox ("You have not passed this assement, please try again")

ElseIf Worksheets("Score Sheet").Range("K21").Value > "64" Then


'Working in Excel 2000-2013


Dim FileExtStr As String
Dim FileFormatNum As Long
Dim Sourcewb As Workbook
Dim Destwb As Workbook
Dim TempFilePath As String
Dim TempFileName As String
Dim OutApp As Object
Dim OutMail As Object


With Application
.ScreenUpdating = False
.EnableEvents = False
End With


Set Sourcewb = ActiveWorkbook


'Copy the ActiveSheet to a new workbook
ActiveSheet.Copy
Set Destwb = ActiveWorkbook


'Determine the Excel version and file extension/format
With Destwb
If Val(Application.Version) < 12 Then
'You use Excel 97-2003
FileExtStr = ".xlsx": FileFormatNum = -4143
Else
'You use Excel 2007-2013
Select Case Sourcewb.FileFormat
Case 51: FileExtStr = ".xlsx": FileFormatNum = 51
Case 52:
If .HasVBProject Then
FileExtStr = ".xlsm": FileFormatNum = 52
Else
FileExtStr = ".xlsx": FileFormatNum = 51
End If
Case 56: FileExtStr = ".xlsx": FileFormatNum = 56
Case Else: FileExtStr = ".xlsb": FileFormatNum = 50
End Select
End If
End With

'Save the new workbook/Mail it/Delete it
TempFilePath = Environ$("temp") & "\"
TempFileName = Worksheets("Score Sheet").Range("D3").Value & " " & Worksheets("Score Sheet").Range("D4").Value & " " & Format(Now, "dd-mmm-yy h-mm-ss")


Set OutApp = CreateObject("Outlook.Application")
Set OutMail = OutApp.CreateItem(0)


With Destwb
.SaveAs TempFilePath & TempFileName & FileExtStr, FileFormat:=FileFormatNum
On Error Resume Next
With OutMail
.to = "email address"
.CC = ""
.BCC = ""
.Subject = TempFileName
.Body = ""
.Attachments.Add Destwb.FullName
.display
.send
SendKeys "^{ENTER}"
End With
On Error GoTo 0
.Close savechanges:=False
End With


'Delete the file you have send
Kill TempFilePath & TempFileName & FileExtStr


Set OutMail = Nothing
Set OutApp = Nothing


With Application
.ScreenUpdating = True
.EnableEvents = True
End With




'Ending Message !NEEDS TO BE UPDATED!
MsgBox ("Thank you for attending this training session, your score has been recorded.")

ThisWorkbook.Saved = True


Application.Quit


End If


End Sub

[SamT]

Try changing this line

'You use Excel 97-2003
FileExtStr = ".xlsx": FileFormatNum = -4143 '<---
To

FileExtStr = ".xls": FileFormatNum = -4143
You are also referring to Range("K51") values (numericals) as strings. I would remove the quotes around the numbers.

I am unable to determine the purpose of checking and changing the file formats. The only file format you are really changing is xlsm's without macros.

The Sourcewb variable is not used.
The Workbook containing "Score Sheet" is not specified. Nit Picking, I know.
You may have to use the FileSystem Object to use the Kill Function

See also:
https://msdn.microsoft.com/en-us/library/office/ff198017.aspx
http://www.rondebruin.nl/mac/mac020.htm