Salary calculation problem

[malarvel]

I have a data in sheet1. I have calculate the salary for all the employee using below code


Private Sub CommandButton1_Click()
Dim i As Integer
Dim totalpay As Double
'Calculate D.A & H.R.A
lastrow = Sheets("sheet1").Range("A" & Rows.Count).End(xlUp).Row
For i = 5 To lastrow
Cells(i, 11) = Round((Cells(i, 10) * Cells(4, 22)), 0)
Cells(i, 12) = Round((Cells(i, 10) * Cells(5, 22)), 0)
'Calculate T.A
Select Case Sheets("sheet1").Cells(i, 8)
Case 1800 Or 1900
Cells(i, 13) = 900 + Round(900 * Cells(i, 22), 0)
Case 2000 Or 2200 Or 2400 Or 2800 Or 4000 Or 4200 Or 4800
Cells(i, 13) = 1800 + Round(1800 * Cells(i, 22), 0)
Case Is >= 5400
Cells(i, 13) = 3600 + Round(3600 * Cells(i, 22), 0)
End Select
totalpay = (Cells(i, 10) + Cells(i, 11) + Cells(i, 12) + Cells(i, 13) + Cells(i, 14) + Cells(i, 15))
Cells(i, 16) = totalpay
Next i
End Sub

In the above code there is no problem for calculating D.A & H.R.A and only problem for calculating T.A for all the employee.

Procedure for calculating T.A is:
1. if grade pay 1800 to 1900 then the T.A is =900+D.A RATE

2. if grade pay 2000 to 4200 then the T.A is =1800+D.A RATE

2. if grade pay 5400 and above then the T.A is =3600+D.A RATE

Kindly give the solution for calculating T.A

[xavier73]

Try this:

Case 1800 To 1900

Case 2000 To 4800

[SamT]

Item "Falls through" Cases until one is matched, then Selecting case is done


Case is <1800
''' Missing
Case is < 1900
'T.A is =900+D.A RATE
Case is <2000
''''Missing
Case is < 4200
'T.A is =1800+D.A RATE
Case is < 5400
''''Missing
Case Else
'T.A is =3600+D.A RATE

[gmaxey]

Sam,

For the conditions defined, wouldn't:



Case Is < 1900:Cells(i, 13) = 900 + Round(900 * Cells(i, 22), 0)
Case Is <5400:Cells(i, 13) = 1800 + Round(1800 * Cells(i, 22), 0)
Case Else:Cells(i, 13) = 3600 + Round(3600 * Cells(i, 22), 0)


be sufficient, or am I missing something?

[SamT]

You probably saw more than I.

Right now, I am:
Building a turkey pen
Next; building a stand so I can move the window AC, 'cuz it drips inside.
Next; Removing the Washroom and central air to fix a leak under the floor. Carrying water to use inside.
Next;Replacing the floor in the 1/4 bathroom
Next; , Remodeling the full bathroom to replace the floor,
Then;Putting skirts around the home

Always Working on the 87 Toyota Pu
always working on the 2000 van

Anyway, I'm not spending a lot of energy here. I just wanted to give the OP some hints on how to improve his existing code.