VBA Code to Rename Folders

Hi All,

I'm working on a code to rename 1000s of folders and I'm afraid that I've hit a dead end. I'm not entirely sure how to proceed. I have an excel document set up like this:

Column B: Original File Source
Column C: New File Source

How do I code somethng that renames every folder in a parent folder? Any help would be much appreciated. My code is below:

Code:

---

Sub FolderRename()
    'Declaring variables
Dim complete_pathof_folder As String, state As String
For i = 2 To Sheets("Sheet1").Range("B2").End(x1Down).Row
 
  'Variable values
        filesource = Cells(i, 2)
        newfilesource = Cells(i, 6)
     
'Renames Original Folder Name
Name completepathof As newfolderpath
Next i
End Sub

---

what error you are getting using this code?

I get "Run-time error '1004': Application-defined or object-defined error" message when I run the code--it highlights "For i=2 to Sheets..." when I try to debug it. Any thoughts?

did you got succes in renaming any of folder? i guess may be folder is not there coz u already renamed it ??

not with this code, no, but the folder names are not changed

Code:

---

Sub M_snb()
  sn = Cells(1, 2).Resize(Cells(Rows.Count, 2).End(xlUp).Row, 2)
 
  For j = 1 To UBound(sn)
      If Dir(sn(j, 1), 16) <> "" and Dir(sn(j, 2), 16) = "" Then Name sn(j, 1) As sn(j, 2)
  Next
End Sub

---

Quote:

---

Originally Posted by jflst

not with this code, no, but the folder names are not changed

---

check for special characters in string name..i dont see any error in code...

For i = 2 To Sheets("Rename File").Range("B2").End(x1Down).Row

I need to debug this. Any thoughts?

Hidden Typo. Add "Option Explicit" at the top of your code page and Debug >> Compile will highlight it for you.

Hint: there is no Lower Case "L" in the following

Code:

---

.End(x1Down).Row

---

now it says I need to define "i" for code line "For i = 2"...How do I define "i"?

Code:

---

dim i as Long

---

This is what I have now--the message "Compile Error: Variabel not defined" pops up and when I debug it it highlights "(xDown). What's wrong with this? Is the iDim in the right place--and do I need to define variables "filesource" and "newfilesource"?

Code:

---

Option Explicit
Sub Folder_Rename1()
    'Declaring variables
Dim filesource As String
Dim newfilesource As String
Dim i As Long
For i = 2 To Sheets("Rename File").Range("B2").End(xDown).Row
 
  'Variable values
        filesource = Cells(i, 2)
        newfilesource = Cells(i, 6)
     
'Renames Original Folder Name
Name filesource As newfilesource
Next i
End Sub
 
    'Possible code that works
  'Repeats Code Until an Empty Cell is Reached
        'Do Until IsEmpty(Cells(iRow, 1))
        'dCellValues(iRow) = Cells(iRow, 2).Value
        'iRow = iRow + 1
        'Loop

---

You wrote so
For i = 2 To Sheets("Rename File").Range("B2").End(xDown).Row
.... and had so
For i = 2 To Sheets("Rename File").Range("B2").End(xlDown).Row

(xlDown)

Syntax error. Change xDown to XLDown.

Did you overlook http://www.vbaexpress.com/forum/show...l=1#post326710 ?

snb's code won't work with Option Explicit, but it will rename all your files really fast. To use it, just comment out the "Option Explicit" line.

If my excel file is set up as follows:

Column B: old file source
Column F: new file source

Where do I make adjustments to snb's code? And does it rename all files until an empty row?

Code:

---

Sub M_snb()
    sn = Cells(1, 2).Resize(Cells(Rows.Count, 2).End(xlUp).Row, 2)
   
    For j = 1 To UBound(sn)
        If Dir(sn(j, 1), 16) <> "" And Dir(sn(j, 2), 16) = "" Then Name sn(j, 1) As sn(j, 2)
    Next
End Sub

---

try to do the first line in his code, then I do the second line.

Sub M_snb()

sn = Cells(2, 2).Resize(Cells(Rows.Count, 2).End(xlUp).Row, 2)

Cells(2,2) refers to the row, column, which in this cse would be B2. I'm not really sure what the Dir string (second line) does. If I'm correct, it's a directory code but I don't knwo what it does.

Also your VBEditor has an F1 button : help.

Code:

---

Sub M_snb()
    sn = Cells(1, 2).Resize(Cells(Rows.Count, 2).End(xlUp).Row, 5)
   
    For j = 1 To UBound(sn)
        If Dir(sn(j, 1), 16) <> "" And Dir(sn(j, 5), 16) = "" Then Name sn(j, 1) As sn(j, 5)
    Next
End Sub

---

Quote:

---

snb's code won't work with Option Explicit, but it will rename all your files really fast. To use it, just comment out the "Option Explicit" line.

---

ergo...

Here we raise the valid question (imo) of using a non 'Option Expicit' environment..

Why.. Why not?

Whilst, i to, do try to Dim my variables.. I am felling that it is to appease traditionalism.. rather than for any logical purpose in today's context..

Having said that.. I may be wrong.. doin the best to work it out.. :)

Quote:

---

Here we raise the valid question (imo) of using a non 'Option Expicit'_(sic) environment..

---

When you're as proficient as snb, you don't need it.

When you're as bad a typist as I am, it is a must have item. Without it, "Expicit" and "Explicit" are two different valid variables, your code might not even raise an error, but still won't produce the right result; With it, VBA will tell me exactly where I goofed.

Which raises the question; "Why should you avoid using "Option Explicit," AKA, the VBE Spell Checker?

When I try to run that I get error message "run-time error '13', type mismatch. Any idea? It tries to debug the code below

If Dir(sn(j, 1), 16) <> "" And Dir(sn(j, 3), 16) = "" Then

You will see with:

Code:

---

msgbox j
msgbox sn(j,1)
msgbox sn(j,3)
If Dir(sn(j, 1), 16) <> "" And Dir(sn(j, 3), 16) = "" Then

---

When I execute that code, three message boxes pop up (as would be expected). The first box, from code "j" delivers a message box that reads "1". The second message box delivers "old name", and where I'm having trouble is that the third message box doesn't deliver "new name" as would be expected. Rather, it delivers a blank message box. Why?

Think about lines 2 and 3 of that code and compare it to the columns in your workbook.

BTW, j = Row number