Solved: Combining macros

[Pete]

Hi Experts

It is possible to run the below macro code for the following worksheet(s):-

Allocation (Vol), Allocation (Vol) and Alloc (Sc.1), Alloc (Sc.2), Alloc (Sc.3)

as you can see i have five macro going to five differnet worksheet(s) the macro is slow and i want is just slight speed it up.......

[VBA]
Sub concat_sc1()
Dim rng As Range
Dim celle As Range
Dim str1 As String
Dim str2 As String
Dim rowe As Long

rowe = 6
str1 = "B"
str2 = "B"
With Sheets("Alloc (Sc.1)")
Set rng = Range(.Cells(rowe, str1), .Cells(.Cells.Rows.Count, str2).End(xlUp))
End With

For Each celle In rng
If celle <> "" Then
celle.Offset(0, 3).FormulaR1C1 = "=VLookup(RC[-3],'Deal Selection'!R9C2:R58C2,1,FALSE)"
celle.Offset(0, 3) = "Vol_" & CStr(celle.Offset(0, 3))
If str1 <> celle.Offset(0, 3) Then
Selection.Borders(xlEdgeTop).LineStyle = xlNone
With celle.Offset(0, 3).Borders(xlEdgeTop)
.LineStyle = xlContinuous
.Weight = xlMedium
.ColorIndex = xlAutomatic
End With
[/VBA]
EDIT: Added VBA Tags - Tommy

[Bob Phillips]

[vba]

Sub concat_sc1()
Dim sh As Worksheet
Dim rng As Range
Dim celle As Range
Dim str1 As String
Dim str2 As String
Dim rowe As Long

For Each sh In Worksheets(Array("Allocation (Vol)", _
"Allocation (Vol) and Alloc (Sc.1)", "Alloc (Sc.2)", "Alloc (Sc.3)"))

rowe = 6
str1 = "B"
str2 = "B"
With sh
Set rng = Range(.Cells(rowe, str1), .Cells(.Cells.Rows.Count, str2).End(xlUp))
End With

For Each celle In rng

If celle <> "" Then

celle.Offset(0, 3).FormulaR1C1 = "=VLookup(RC[-3]," _
'Deal Selection'!R9C2:R58C2,1,FALSE)"
celle.Offset(0, 3) = "Vol_" & CStr(celle.Offset(0, 3))
If str1 <> celle.Offset(0, 3) Then

celle.Borders(xlEdgeTop).LineStyle = xlNone
With celle.Offset(0, 3).Borders(xlEdgeTop)
.LineStyle = xlContinuous
.Weight = xlMedium
.ColorIndex = xlAutomatic
End With


'...
Next sh
[/vba]
Edit Lucas: Line breaks added.....

[Pete]

thanks for the feed back XLD..............
let me test it and get back you

[Pete]

ok get a compile without next error

[vba]
Sub concat_sc1()
Dim sh As Worksheet
Dim rng As Range
Dim celle As Range
Dim str1 As String
Dim str2 As String
Dim rowe As Long

For Each sh In Worksheets(Array("Allocation (Vol)", _
"Allocation (Vol) and Alloc (Sc.1)", "Alloc (Sc.2)", "Alloc (Sc.3)"))

rowe = 6
str1 = "B"
str2 = "B"
With sh
Set rng = Range(.Cells(rowe, str1), .Cells(.Cells.Rows.Count, str2).End(xlUp))
End With

For Each celle In rng

If celle <> "" Then

celle.Offset(0, 3).FormulaR1C1 = "=VLookup(RC[-3],'Deal Selection'!R9C2:R58C2,1,FALSE)"
celle.Offset(0, 3) = "Vol_" & CStr(celle.Offset(0, 3))
If str1 <> celle.Offset(0, 3) Then

celle.Borders(xlEdgeTop).LineStyle = xlNone
With celle.Offset(0, 3).Borders(xlEdgeTop)
.LineStyle = xlContinuous
.Weight = xlMedium
.ColorIndex = xlAutomatic
End With
str1 = celle.Offset(0, 3)
End If
celle.Offset(0, 3).FormulaR1C1 = "=VLookup(RC[-2],'Deal Selection'!R9C9:R58C9,1,FALSE)"
celle.Offset(0, 3) = str1 & " _" & CStr(celle.Offset(0, 3))
End If
Next celle
End Sub
[/vba]

EDIT: Added the VBA tags Tommy

[lucas]

shouldn't this be next sh[vba]
Next celle
[/vba]

[Pete]

changed it

Say "invaild Next control varibale reference"

[figment]

add a Next before the End Sub

[Tommy]

Per everone's comments
[vba]
Sub concat_sc1()
Dim sh As Worksheet
Dim rng As Range
Dim celle As Range
Dim str1 As String
Dim str2 As String
Dim rowe As Long
For Each sh In Worksheets(Array("Allocation (Vol)", _
"Allocation (Vol) and Alloc (Sc.1)", "Alloc (Sc.2)", "Alloc (Sc.3)"))
rowe = 6
str1 = "B"
str2 = "B"
With sh
Set rng = Range(.Cells(rowe, str1), .Cells(.Cells.Rows.Count, str2).End(xlUp))
End With
For Each celle In rng
If celle <> "" Then
celle.Offset(0, 3).FormulaR1C1 = "=VLookup(RC[-3],'Deal Selection'!R9C2:R58C2,1,FALSE)"
celle.Offset(0, 3) = "Vol_" & CStr(celle.Offset(0, 3))
If str1 <> celle.Offset(0, 3) Then
celle.Borders(xlEdgeTop).LineStyle = xlNone
With celle.Offset(0, 3).Borders(xlEdgeTop)
.LineStyle = xlContinuous
.Weight = xlMedium
.ColorIndex = xlAutomatic
End With
str1 = celle.Offset(0, 3)
End If
celle.Offset(0, 3).FormulaR1C1 = "=VLookup(RC[-2],'Deal Selection'!R9C9:R58C9,1,FALSE)"
celle.Offset(0, 3) = str1 & " _" & CStr(celle.Offset(0, 3))
End If
Next celle
Next sh
End Sub

[/vba]

It helps to post the whole sub to begin with so there is no confusion on anyone's part.

EDIT: Fixed my own stuff LOL Tommy

[Pete]

error with this line:

For Each sh In Worksheets(Array("Allocation (Vol)", _
"Allocation (Vol) and Alloc (Sc.1)", "Alloc (Sc.2)", "Alloc (Sc.3)"))

[Tommy]

If the error is subscript out of range it is because one of the sheets does not exist.

Otherwise tells us what the error is and we may be able to help more.

[Pete]

syntax error
For Each sh In Worksheets(Array("Allocation (Vol)", _

[Tommy]

I don't get the error, I did test it so try this
[VBA]For Each sh In Worksheets(Array("Allocation (Vol)", "Allocation (Vol) and Alloc (Sc.1)", "Alloc (Sc.2)", "Alloc (Sc.3)")) [/VBA]

[Bob Phillips]

I am unable to name a sheet 'Allocation (Vol) and Alloc (Sc.1)', it is too long. How did you manage?