Excel file close

[trevb]

Hi, can someone help please.....
I have entered the following code but for some reason when the No button is clicked nothing happens and I have to click it a second time to close the file, the Yes button works fine ?
Am I missing something really obvious ?
Any help much appreciated.

Private Sub Workbook_BeforeClose(Cancel As Boolean)
Dim Ans As String
Ans = MsgBox("Do you want to save the workbook?", vbYesNo)
Select Case Ans
Case vbYes
ThisWorkbook.Save
Case vbNo
ActiveWorkbook.Close False
End Select
End Sub

Regards T

[Bob Phillips]

What do you want to happen, your code says don't close it.

[trevb]

On vbYes save and close and vbNo close the workbook

[Bob Phillips]

Just remove

[vba]
Private Sub Workbook_BeforeClose(Cancel As Boolean)
Dim Ans As String
Ans = MsgBox("Do you want to save the workbook?", vbYesNo)
Select Case Ans
Case vbYes
ThisWorkbook.Save
Case vbNo
ThisWorkbook.Saved=True
End Select
End Sub
[/vba]

[trevb]

Many thanks xld works fine.