Solved: macro doesn't work

[hunna]

I am trying to write a code that runs certain macros until the last used cell in column A. The code is not working could anybody help me with this?

Sub ds()


Dim i As Integer
Dim intRowCount As Integer


intRowCount = Range("A2").CurrentRegion.Rows.Count - 1
For i = 2 To intRowCount

If Not Cells(i, 1).Value = "" Then
TextBox1.Value = Cells(i, 1).Value
TextBox2.Value = Cells(i, 2).Value
TextBox3.Value = Cells(i, 3).Value
TextBox4.Value = Cells(i, 4).Value

    If Not Cells(i, 7).Value = "" Then
    MsgBox "modification"

    Else
    MsgBox "No modification"
    
    End If
    
Else
MsgBox "try again"

End If
    
Next i

End Sub

any help is greatly appreciated.

[mdmackillop]

Your data may not be contiguous
Try
[VBA]
intRowCount = Range("A" & rows.count).end(xlup).row -1
[/VBA]

[omp001]

without knowing exactly what you want to get, try this way
[vba]Sub ds()

Dim i As Integer
Dim intRowCount As Integer

With ActiveSheet
intRowCount = .Range("A2").CurrentRegion.Rows.Count - 1
For i = 2 To intRowCount

If Not .Cells(i, 1).Value = "" Then
.TextBox1.Value = .Cells(i, 1).Value
.TextBox2.Value = .Cells(i, 2).Value
.TextBox3.Value = .Cells(i, 3).Value
.TextBox4.Value = .Cells(i, 4).Value

If Not .Cells(i, 7).Value = "" Then
MsgBox "modification"

Else
MsgBox "No modification"

End If

Else
MsgBox "try again"

End If

Next i
End With
End Sub
[/vba]

[Aflatoon]

A couple of observations, if I may:
1. It would be helpful is you were specific about how the code fails. Do you get an error? If so, what and where? Or does it not do what you want? If so, in what way is it incorrect?
2. Do not use Integers as row counter variables. Use Long instead. Integers can only go up to 32,767 and there are a lot more rows than that in a worksheet.

[hunna]

Thank you all for kind help.