Solved: MsgBox problem

[viper]

When I use this code I get the response for a yes answer even when no is clicked. What is wrong?

[VBA]
MsgBox "Do you want to find someone else? ", vbYesNo, ""
If vbYes Then
UserForm1.Show
Else
Exit Sub
End If

[/VBA]

If I click no I still get the userform to show. This happens to me all the time and I get frustrated and use a second userform just to get the result I want.

Thanks for any advice, help, or beer!

[malik641]

Hi Viper Welcome to the forums!

I can't explain why that is happening the way it is...and sorry I can't send ya any beer ...but try this:
[VBA]
Sub Userform()
If MsgBox("Do you want to find someone else? ", vbYesNo, "") = vbYes Then
UserForm1.Show
Else
Exit Sub
End If
End Sub
[/VBA]
HTH

[vonpookie]

Basically, you are selecting a response, but it is not connected to the values in the If statement at all. If that makes any sense (which it probably doesn't).

Malik's got the right idea, but I usually just use a variable, myself:

[vba]Dim ans As Variant

ans = MsgBox("Do you want to find someone else? ", vbYesNo)
If ans = vbYes Then
UserForm1.Show
Else
Exit Sub
End If[/vba]

[Killian]

Joesph's code is the way to go.
The reason being that MsgBox is a function that returns a value (depending on which button is clicked)
So you test the value the function throws back in the same line (in this case vbYes which is a xl constant - value: 6)... then do something

Hope that explains it

[viper]

Thanks each of you. I understand now. Never stop learning, everyday is a learning experience at some level.

[sheeeng]

Joesph's code is the way to go.
The reason being that MsgBox is a function that returns a value (depending on which button is clicked)
So you test the value the function throws back in the same line (in this case vbYes which is a xl constant - value: 6)... then do something

Hope that explains it

Hello Viper! Welcome to VBAX!

Support Joseph idea here.

[malik641]

Joesph's code is the way to go.

Support Joseph idea here.

Thanks for the support guys!

Thanks each of you. I understand now. Never stop learning, everyday is a learning experience at some level.

Glad to help! And no, never stop learning