Consulting

Results 1 to 5 of 5

Thread: Create Hyperlinks based on selection and cell contents

  1. #1

    Question Create Hyperlinks based on selection and cell contents

    hello all and thanks in advance

    im trying to create a macro whereby a user can select a range of cells, runs a macro and a hyperlink is automatically to each cell. The hyperlink will be a combination of static text and whatever is in each cell.

    below is what i have started - it is adding a hyperlink to all the cells, but the problem is the actual hyperlink URL is not updating for each subsequent cell and its contents - it is showing the same hyperlink for all cells based on the first active cell

    thanks
    Shaun

    Sub Hyperlink()
    Dim newRange As Range
    Dim newCell As Range
    Set newRange = Selection
    For Each newCell In newRange
       With ActiveSheet
          .Hyperlinks.Add Anchor:=newRange, _
          Address:="pronto:%20/u/pronto/data/L25%20drilldown%20job-code%20" & ActiveCell.Text, TextToDisplay:=ActiveCell.Text
       End With
    Next newCell
    End Sub
    Last edited by Aussiebear; 03-18-2023 at 03:13 PM. Reason: Added code tags to supplied code

  2. #2
    VBAX Mentor
    Joined
    Nov 2022
    Location
    The Great Land
    Posts
    323
    Location
    Try:

    newCell.Text

    or

    newCell.Value

    instead of ActiveCell.Text
    How to attach file: How to upload your attachments (vbaexpress.com) To provide db: copy, remove confidential data, run compact & repair, zip w/Windows Compression.

  3. #3
    Sorry Jun7 - no good (same result) ...

  4. #4
    VBAX Sage
    Joined
    Apr 2007
    Location
    United States
    Posts
    8,711
    Location
    I think this is what you were asking

    I made a few cleanups. I don't like to use Activesheet, eiither a named one or a range's parent, since you can never count on the sheet that you "think'" is active actually being the ActiveSheet. Personal opinion -- your choice

    Option Explicit
    
    Sub AddHyperlinksToSelection()
        Dim newCell As Range
    
        For Each newCell In Selection
            Selection.Parent.Hyperlinks.Add _
                Anchor:=newCell, Address:="pronto:%20/u/pronto/data/L25%20drilldown%20job-code%20" & newCell.Text, TextToDisplay:=newCell.Text
        Next newCell
    End Sub
    Capture.JPG
    Attached Files Attached Files
    ---------------------------------------------------------------------------------------------------------------------

    Paul


    Remember: Tell us WHAT you want to do, not HOW you think you want to do it

    1. Use [CODE] ....[/CODE ] Tags for readability
    [CODE]PasteYourCodeHere[/CODE ] -- (or paste your code, select it, click [#] button)
    2. Upload an example
    Go Advanced / Attachments - Manage Attachments / Add Files / Select Files / Select the file(s) / Upload Files / Done
    3. Mark the thread as [Solved] when you have an answer
    Thread Tools (on the top right corner, above the first message)
    4. Read the Forum FAQ, especially the part about cross-posting in other forums
    http://www.vbaexpress.com/forum/faq...._new_faq_item3

  5. #5
    Moderator VBAX Guru Aussiebear's Avatar
    Joined
    Dec 2005
    Location
    Queensland
    Posts
    4,997
    Location
    Very similar to Paul's, but in this case naming the sheet.
    Option Explicit
     
    Sub AddHyperlinksToSelection()
    Dim newCell As Range
    With Sheets(“Sheet1”) ---< Change this to suit actual sheet name
        For Each newCell In Selection
            Selection.Parent.Hyperlinks.Add _
            Anchor:=newCell, Address:="pronto:%20/u/pronto/data/L25%20drilldown%20job-code%20" & newCell.Text, TextToDisplay:=newCell.Text
        Next newCell
    End With
    End Sub
    My first impression with the original code was that the loop was started and then you went to the With, End With whereas both Paul and myself have the loop performing inside of the With, End With.
    Remember To Do the Following....
    Use [Code].... [/Code] tags when posting code to the thread.
    Mark your thread as Solved if satisfied by using the Thread Tools options.
    If posting the same issue to another forum please show the link

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •