Add dashes between letters

[Logit]

I reduced your existing macro to :

Option Explicit

Sub AddDashes1()
    Dim Cell As Range
    Dim sTemp As String
    Dim C As Integer
    For Each Cell In Selection
        sTemp = ""
        For C = 1 To Len(Cell)
            sTemp = sTemp + Mid(Cell, C, 1) + "-"
        Next
        Cell.Value = Left(sTemp, Len(sTemp) - 1)
    Next
End Sub

Select the cell and click the button.